Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print scheduler call stack when SIGUSR2 received #47311

Merged
merged 6 commits into from
Mar 7, 2025
Merged

Print scheduler call stack when SIGUSR2 received #47311

merged 6 commits into from
Mar 7, 2025
+14 −1

Conversation

Jeffrharr
Copy link
Contributor

@Jeffrharr Jeffrharr commented Mar 3, 2025 •
edited
Loading

closes: #47084

logs the stacktrace for each thread of the SchedulerJobRunner when SIGUSR2 signal is recieved.

Note for reviewers:
I set the stacktrace limit to 10, but we can increase that bound or make it a parameter in the class.

Example output - from unit test without mocks:

----------------------------------------------- Captured log call ------------------------------------------------
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:260 --------------------------------------------------------------------------------
SIGHUP received, printing debug
--------------------------------------------------------------------------------
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:263 Debug dump for the executor <MagicMock name='DefaultExecutor' id='140021473292144'>
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:265 --------------------------------------------------------------------------------
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:268 Debug dump for the executor <MagicMock name='DefaultExecutor' id='140021473292144'>
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:270 --------------------------------------------------------------------------------
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:263 Debug dump for the executor <MagicMock name='SeconadaryExecutor' id='140021472362016'>
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:265 --------------------------------------------------------------------------------
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:268 Debug dump for the executor <MagicMock name='SeconadaryExecutor' id='140021472362016'>
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:270 --------------------------------------------------------------------------------
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:275 Stack Trace for Scheduler Job Runner on thread: Thread-1
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:277 <FrameSummary file /usr/local/lib/python3.9/threading.py, line 937 in _bootstrap>
        <FrameSummary file /usr/local/lib/python3.9/threading.py, line 980 in _bootstrap_inner>
        <FrameSummary file /usr/local/lib/python3.9/threading.py, line 917 in run>
        <FrameSummary file /usr/local/lib/python3.9/site-packages/pytest_rerunfailures.py, line 440 in run_server>
        <FrameSummary file /usr/local/lib/python3.9/socket.py, line 293 in accept>
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:278 --------------------------------------------------------------------------------
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:275 Stack Trace for Scheduler Job Runner on thread: MainThread
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:277 <FrameSummary file /usr/local/lib/python3.9/site-packages/pluggy/_callers.py, line 103 in _multicall>
        <FrameSummary file /usr/local/lib/python3.9/site-packages/_pytest/runner.py, line 174 in pytest_runtest_call>
        <FrameSummary file /usr/local/lib/python3.9/site-packages/_pytest/python.py, line 1627 in runtest>
        <FrameSummary file /usr/local/lib/python3.9/site-packages/pluggy/_hooks.py, line 513 in __call__>
        <FrameSummary file /usr/local/lib/python3.9/site-packages/pluggy/_manager.py, line 120 in _hookexec>
        <FrameSummary file /usr/local/lib/python3.9/site-packages/pluggy/_callers.py, line 103 in _multicall>
        <FrameSummary file /usr/local/lib/python3.9/site-packages/_pytest/python.py, line 159 in pytest_pyfunc_call>
        <FrameSummary file /usr/local/lib/python3.9/unittest/mock.py, line 1768 in _inner>
        <FrameSummary file /opt/airflow/tests/jobs/test_scheduler_job.py, line 626 in test_executor_debug_dump>
        <FrameSummary file /opt/airflow/airflow/jobs/scheduler_job_runner.py, line 276 in _debug_dump>
INFO     airflow.jobs.scheduler_job_runner.SchedulerJobRunner:scheduler_job_runner.py:278 --------------------------------------------------------------------------------

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Mar 3, 2025
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Mar 3, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Jeffrharr Jeffrharr marked this pull request as ready for review March 3, 2025 19:06
@Jeffrharr Jeffrharr requested review from ashb and XD-DENG as code owners March 3, 2025 19:06
@Jeffrharr Jeffrharr mentioned this pull request Mar 6, 2025
Closed
2 tasks
@Jeffrharr
Copy link
Contributor Author

@potiuk are you able to approve workflows?

@Jeffrharr
Copy link
Contributor Author

@potiuk are you able to approve workflows?

Sorry, one more time. Hit update instead of merge and it has to rerun tests.

I believe those workflows should work for me after making this initial commit?

@o-nikolas
Copy link
Contributor

@potiuk are you able to approve workflows?

Sorry, one more time. Hit update instead of merge and it has to rerun tests.

I believe those workflows should work for me after making this initial commit?

Approved. Yupp, once you've got your first commit merged, you should be able to approve them yourself 🥳

@potiuk potiuk merged commit f0de8a9 into apache:main Mar 7, 2025
44 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Mar 7, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

Assignees
No one assigned
Labels
area:Scheduler including HA (high availability) scheduler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print scheduler call stack when SIGUSR2 signal is received
4 participants
@Jeffrharr @o-nikolas @potiuk @jeffrey-harrison